From: Fernando Fernandez Mancera Date: Wed, 4 Sep 2019 12:29:07 +0000 (+0200) Subject: netfilter: nf_tables: fix possible null-pointer dereference in object update X-Git-Tag: v5.4-rc1~131^2~59^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=aa4095a156b56b00ca202d482b40d191ef5c54e8;p=thirdparty%2Fkernel%2Flinux.git netfilter: nf_tables: fix possible null-pointer dereference in object update Not all objects have an update operation. If the object type doesn't implement an update operation and the user tries to update it will hit EOPNOTSUPP. Fixes: d62d0ba97b58 ("netfilter: nf_tables: Introduce stateful object update operation") Signed-off-by: Fernando Fernandez Mancera Signed-off-by: Pablo Neira Ayuso --- diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index cf767bc58e188..013d28899cabc 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -5140,6 +5140,9 @@ static int nf_tables_updobj(const struct nft_ctx *ctx, struct nft_trans *trans; int err; + if (!obj->ops->update) + return -EOPNOTSUPP; + trans = nft_trans_alloc(ctx, NFT_MSG_NEWOBJ, sizeof(struct nft_trans_obj)); if (!trans)