From: Mark Wielaard Date: Sun, 21 Jan 2024 23:12:45 +0000 (+0100) Subject: libsframe: Fix calloc argument order in dump_sframe_header X-Git-Tag: gdb-15-branchpoint~1177 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=aa5a36b118ade63ebb189a8a51ef5e9c7ea30505;p=thirdparty%2Fbinutils-gdb.git libsframe: Fix calloc argument order in dump_sframe_header GCC14 warns about the order of the arguments to calloc libsframe/sframe-dump.c: In function ‘dump_sframe_header’: libsframe/sframe-dump.c:70:39: warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args] 70 | flags_str = (char*) calloc (sizeof (char), SFRAME_HEADER_FLAGS_STR_MAX_LEN); | ^~~~ libsframe/sframe-dump.c:70:39: note: earlier argument should specify number of elements, later size of each element Fix this by swapping the size and count arguments. libsframe/ * sframe-dump.c (dump_sframe_header): Swap arguments to calloc --- diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c index 0d596918f72..42a086a5691 100644 --- a/libsframe/sframe-dump.c +++ b/libsframe/sframe-dump.c @@ -67,7 +67,7 @@ dump_sframe_header (sframe_decoder_ctx *sfd_ctx) /* Prepare SFrame section flags string. */ flags = header->sfh_preamble.sfp_flags; - flags_str = (char*) calloc (sizeof (char), SFRAME_HEADER_FLAGS_STR_MAX_LEN); + flags_str = (char*) calloc (SFRAME_HEADER_FLAGS_STR_MAX_LEN, sizeof (char)); if (flags) { if (flags & SFRAME_F_FDE_SORTED)