From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Date: Tue, 8 Jul 2025 10:08:20 +0000 (+0200)
Subject: efi_loader: efi_realloc() must check efi_alloc() return value
X-Git-Tag: v2025.10-rc1~7^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=aa703a816a62deb876a1e77ccff030a7cc60f344;p=thirdparty%2Fu-boot.git

efi_loader: efi_realloc() must check efi_alloc() return value

Avoid copying to NULL if out of memory.

Fixes: 3c08df58cc43 ("lib: efi_loader: efi_memory.c: add efi_realloc() for realloc memory")
Addresses-Coverity-ID: 569499: Null pointer dereferences (NULL_RETURNS)
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---

diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c
index 6dfc698a247..b77c2f980cc 100644
--- a/lib/efi_loader/efi_memory.c
+++ b/lib/efi_loader/efi_memory.c
@@ -714,6 +714,8 @@ efi_status_t efi_realloc(void **ptr, size_t size)
 		sizeof(struct efi_pool_allocation);
 
 	new_ptr = efi_alloc(size);
+	if (!new_ptr)
+		return EFI_OUT_OF_RESOURCES;
 
 	/* copy old data to new alloced buffer */
 	memcpy(new_ptr, *ptr, min(size, old_size));