From: Kevin Wolf <kwolf@redhat.com>
Date: Mon, 14 Mar 2016 12:16:51 +0000 (+0100)
Subject: block: Remove cache.writeback from blockdev-add
X-Git-Tag: v2.6.0-rc0~4^2~44
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=aaa436f9982ebf3988c9a25661c96bca97b259b0;p=thirdparty%2Fqemu.git

block: Remove cache.writeback from blockdev-add

The WCE bit is a frontend property and should not be part of the backend
configuration. This is especially important because the same BDS can be
used by different users with different WCE requirements.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---

diff --git a/qapi/block-core.json b/qapi/block-core.json
index b1cf77dffab..a9913f034a8 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1614,7 +1614,6 @@
 #
 # Includes cache-related options for block devices
 #
-# @writeback:   #optional enables writeback mode for any caches (default: true)
 # @direct:      #optional enables use of O_DIRECT (bypass the host page cache;
 #               default: false)
 # @no-flush:    #optional ignore any flush requests for the device (default:
@@ -1623,8 +1622,7 @@
 # Since: 1.7
 ##
 { 'struct': 'BlockdevCacheOptions',
-  'data': { '*writeback': 'bool',
-            '*direct': 'bool',
+  'data': { '*direct': 'bool',
             '*no-flush': 'bool' } }
 
 ##