From: Martin Kletzander <mkletzan@redhat.com>
Date: Wed, 16 Apr 2025 07:38:53 +0000 (+0200)
Subject: nwfilter: Fix erroneous pointer passing to g_clear_pointer
X-Git-Tag: v11.3.0-rc1~13
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ab1218c610758ce43516f690dc2136d00d859a07;p=thirdparty%2Flibvirt.git

nwfilter: Fix erroneous pointer passing to g_clear_pointer

Commit 5de27c32a18f wanted to fix a possible double free, but by mistake
did not pass a reference to the variable.  This made virtnwfilterd
coredump in our daily CI build.

Fixes: 5de27c32a18f1da4969a679a2385d45cf0279699
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
---

diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c
index 0c12b54b80..1465734a54 100644
--- a/src/nwfilter/nwfilter_gentech_driver.c
+++ b/src/nwfilter/nwfilter_gentech_driver.c
@@ -203,12 +203,12 @@ virNWFilterInstReset(virNWFilterInst *inst)
 
     for (i = 0; i < inst->nfilters; i++)
         virNWFilterObjUnlock(inst->filters[i]);
-    g_clear_pointer(inst->filters, g_free);
+    g_clear_pointer(&inst->filters, g_free);
     inst->nfilters = 0;
 
     for (i = 0; i < inst->nrules; i++)
         virNWFilterRuleInstFree(inst->rules[i]);
-    g_clear_pointer(inst->rules, g_free);
+    g_clear_pointer(&inst->rules, g_free);
     inst->nrules = 0;
 }