From: Christophe Kerello Date: Tue, 21 Jul 2020 09:52:07 +0000 (+0200) Subject: mtd: rawnand: stm32_fmc2: fix a buffer overflow X-Git-Tag: v5.10-rc1~94^2~3^2~22 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ab16f54ef3cdb6bbc06a36f636a89e6db8a6cea3;p=thirdparty%2Flinux.git mtd: rawnand: stm32_fmc2: fix a buffer overflow This patch solves following static checker warning: drivers/mtd/nand/raw/stm32_fmc2_nand.c:350 stm32_fmc2_nfc_select_chip() error: buffer overflow 'nfc->data_phys_addr' 2 <= 2 The CS value can only be 0 or 1. Signed-off-by: Christophe Kerello Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver") Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/1595325127-32693-1-git-send-email-christophe.kerello@st.com --- diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c index ba679d2cc743d..b31a5818234d3 100644 --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c @@ -1763,7 +1763,7 @@ static int stm32_fmc2_nfc_parse_child(struct stm32_fmc2_nfc *nfc, return ret; } - if (cs > FMC2_MAX_CE) { + if (cs >= FMC2_MAX_CE) { dev_err(nfc->dev, "invalid reg value: %d\n", cs); return -EINVAL; }