From: Liao Chen <liaochen4@huawei.com>
Date: Sat, 21 Sep 2024 06:29:56 +0000 (+0000)
Subject: scsi: qedf: Remove dead code
X-Git-Tag: v6.13-rc1~81^2~52
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ab19e3154cc12fdf6c39b6e0a2ed518e45d9f876;p=thirdparty%2Fkernel%2Flinux.git

scsi: qedf: Remove dead code

If container_of() is used correctly, its result is never NULL. Remove the
code that depends on container_of() returning a NULL pointer.

Signed-off-by: Liao Chen <liaochen4@huawei.com>
Link: https://lore.kernel.org/r/20240921062956.2027563-1-liaochen4@huawei.com
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index cf13148ba281c..df756f3eef3e8 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -4018,11 +4018,6 @@ void qedf_stag_change_work(struct work_struct *work)
 	struct qedf_ctx *qedf =
 	    container_of(work, struct qedf_ctx, stag_work.work);
 
-	if (!qedf) {
-		QEDF_ERR(&qedf->dbg_ctx, "qedf is NULL");
-		return;
-	}
-
 	if (test_bit(QEDF_IN_RECOVERY, &qedf->flags)) {
 		QEDF_ERR(&qedf->dbg_ctx,
 			 "Already is in recovery, hence not calling software context reset.\n");