From: Thomas Weißschuh <thomas@t-8ch.de>
Date: Fri, 22 Sep 2023 09:19:24 +0000 (+0200)
Subject: ci: don't combine -Werror and -fsanitize
X-Git-Tag: v2.40-rc1~232^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ab37a96d075907ecb857b4d983761db1af102598;p=thirdparty%2Futil-linux.git

ci: don't combine -Werror and -fsanitize

As explained in [0]:

    Note that sanitizers tend to increase the rate of false positive
    warnings, most notably those around -Wmaybe-uninitialized. We recommend
    against combining -Werror and [the use of] sanitizers.

[0] https://gcc.gnu.org/onlinedocs/gcc-13.2.0/gcc/Instrumentation-Options.html#index-fsanitize_003dundefined

Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
---

diff --git a/.github/workflows/cibuild.sh b/.github/workflows/cibuild.sh
index 6bb10862f4..dfcf91c757 100755
--- a/.github/workflows/cibuild.sh
+++ b/.github/workflows/cibuild.sh
@@ -83,7 +83,6 @@ for phase in "${PHASES[@]}"; do
             --disable-use-tty-group
             --disable-makeinstall-chown
             --enable-all-programs
-            --enable-werror
         )
 
         if [[ "$COVERAGE" == "yes" ]]; then
@@ -94,6 +93,8 @@ for phase in "${PHASES[@]}"; do
             opts+=(--enable-asan --enable-ubsan)
             CFLAGS+=(-fno-omit-frame-pointer)
             CXXFLAGS+=(-fno-omit-frame-pointer)
+        else
+            opts+=(--enable-werror)
         fi
 
         if [[ "$COMPILER" == clang* && "$SANITIZE" == "yes" ]]; then