From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Tue, 4 Feb 2025 08:48:24 +0000 (+0100)
Subject: Handle a few remaining remnants of POC code
X-Git-Tag: dnsdist-2.0.0-alpha1~95^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ab431fb092e74b172630824b64d04eb915755dc4;p=thirdparty%2Fpdns.git

Handle a few remaining remnants of POC code
---

diff --git a/pdns/recursordist/rec-rust-lib/table.py b/pdns/recursordist/rec-rust-lib/table.py
index 93600481b8..e07e176a65 100644
--- a/pdns/recursordist/rec-rust-lib/table.py
+++ b/pdns/recursordist/rec-rust-lib/table.py
@@ -3208,10 +3208,10 @@ IP address for the webserver to listen on.
         'section' : 'webservice',
         'type' : LType.ListIncomingWSConfigs,
         'default' : '',
-        'help' : 'XXXX',
+        'help' : 'IP addresses and associated attributes for the webserver to listen on',
         'doc' : '''
 IP addresses and associated attributes for the webserver to listen on.
-If this setting has a non-default value, :ref:`setting-yaml-webservice.address` and :ref:`setting-yaml-webservice.port` will be ignored.
+If this setting has a non-default value, :ref:`setting-yaml-webservice.address` and :ref:`setting-yaml-webservice.port` will be ignored. Note multiple listen addresses can be configured and https is supported as well, in contrast to earlier (pre 5.3.0) versions.
  ''',
         'skip-old': 'No equivalent old-style setting',
         'versionadded': '5.3.0',
diff --git a/pdns/recursordist/reczones.cc b/pdns/recursordist/reczones.cc
index b92d6daed6..d40df7a31f 100644
--- a/pdns/recursordist/reczones.cc
+++ b/pdns/recursordist/reczones.cc
@@ -34,11 +34,7 @@
 #include "zoneparser-tng.hh"
 #include "rec-rust-lib/cxxsettings.hh"
 #include "rec-system-resolve.hh"
-
-// XXX consider including rec-main.hh?
-extern int g_argc;
-extern char** g_argv;
-extern string g_yamlSettingsSuffix;
+#include "rec-main.hh"
 
 bool primeHints(time_t now)
 {
@@ -198,7 +194,6 @@ string reloadZoneConfiguration(bool yaml)
       oldAndNewDomains.insert(entry.first);
     }
 
-    extern LockGuarded<std::shared_ptr<SyncRes::domainmap_t>> g_initialDomainMap; // XXX
     {
       auto lock = g_initialDomainMap.lock();
       if (*lock) {
@@ -221,7 +216,6 @@ string reloadZoneConfiguration(bool yaml)
       wipeCaches(entry, true, 0xffff);
     }
     *g_initialDomainMap.lock() = std::move(newDomainMap);
-    extern LockGuarded<std::shared_ptr<notifyset_t>> g_initialAllowNotifyFor; // XXX
     *g_initialAllowNotifyFor.lock() = std::move(newNotifySet);
     return "ok\n";
   }