From: Michael Tremer <michael.tremer@ipfire.org>
Date: Thu, 27 Mar 2025 11:41:56 +0000 (+0000)
Subject: config: Fix double-used attribute name in logger
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ab9484f5a4138001e4d7d2b6ca0d3ad6fba86881;p=pbs.git

config: Fix double-used attribute name in logger

The method "log" could never be called because it was overwritten by the
logger.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/buildservice/config.py b/src/buildservice/config.py
index 140c4fb2..86b0071b 100644
--- a/src/buildservice/config.py
+++ b/src/buildservice/config.py
@@ -144,15 +144,15 @@ class PakfireLogger(object):
 			self.queue.append(record)
 
 	def __init__(self, level=logging.DEBUG):
-		# Create a new child logger
-		self.log = log.getChild("logger-%s" % self.id)
-		self.log.setLevel(level)
-
 		# Increment the ID
 		self.id += 1
 
-		# Propagate messages to the parent logger
-		self.log.propagate = True
+		# Create a new child logger
+		self.logger = log.getChild("logger-%s" % self.id)
+		self.logger.setLevel(level)
+
+		# Don't propagate messages to the parent logger
+		self.logger.propagate = False
 
 		# Create a new queue to buffer any messages
 		self.queue = collections.deque()
@@ -167,7 +167,7 @@ class PakfireLogger(object):
 		handler.setFormatter(formatter)
 
 		# Register the queue with the logger
-		self.log.addHandler(handler)
+		self.logger.addHandler(handler)
 
 	def __str__(self):
 		"""
@@ -179,4 +179,4 @@ class PakfireLogger(object):
 		"""
 			Logs a message
 		"""
-		return self.log.log(*args, **kwargs)
+		return self.logger.log(*args, **kwargs)