From: Tom Tromey <tom@tromey.com>
Date: Thu, 17 Oct 2024 22:57:03 +0000 (-0600)
Subject: Use gdb_bfd_get_full_section_contents in auto-load.c
X-Git-Tag: gdb-16-branchpoint~604
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=abbc4d4435aade0773974f05acaff2fab67dbf78;p=thirdparty%2Fbinutils-gdb.git

Use gdb_bfd_get_full_section_contents in auto-load.c

This changes auto-load.c ot use gdb_bfd_get_full_section_contents.
This shouldn't change any behavior, but makes it easier to add locking
in a subsequent patch.

Reviewed-by: Kevin Buettner <kevinb@redhat.com>
---

diff --git a/gdb/auto-load.c b/gdb/auto-load.c
index e753333b1cd..d4307eac627 100644
--- a/gdb/auto-load.c
+++ b/gdb/auto-load.c
@@ -1114,25 +1114,22 @@ auto_load_section_scripts (struct objfile *objfile, const char *section_name)
 {
   bfd *abfd = objfile->obfd.get ();
   asection *scripts_sect;
-  bfd_byte *data = NULL;
 
   scripts_sect = bfd_get_section_by_name (abfd, section_name);
   if (scripts_sect == NULL
       || (bfd_section_flags (scripts_sect) & SEC_HAS_CONTENTS) == 0)
     return;
 
-  if (!bfd_get_full_section_contents (abfd, scripts_sect, &data))
+  gdb::byte_vector data;
+  if (!gdb_bfd_get_full_section_contents (abfd, scripts_sect, &data))
     warning (_("Couldn't read %s section of %ps"),
 	     section_name,
 	     styled_string (file_name_style.style (),
 			    bfd_get_filename (abfd)));
   else
     {
-      gdb::unique_xmalloc_ptr<bfd_byte> data_holder (data);
-
-      char *p = (char *) data;
-      source_section_scripts (objfile, section_name, p,
-			      p + bfd_section_size (scripts_sect));
+      const char *p = (const char *) data.data ();
+      source_section_scripts (objfile, section_name, p, p + data.size ());
     }
 }