From: Christopher Faulet <cfaulet@haproxy.com>
Date: Fri, 30 Jan 2026 08:51:00 +0000 (+0100)
Subject: BUG/MEDIUM: applet: Fix test on shut flags for legacy applets
X-Git-Tag: v3.4-dev4~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=abc1947e1;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: applet: Fix test on shut flags for legacy applets

A regression was introduced in the commit 0ea601127 ("BUG/MAJOR: applet: Don't
call I/O handler if the applet was shut"). The test on shut flags for legacy
applets is inverted.

It should be harmeless on 3.4 and 3.3 because all applets were converted. But
this fix is mandatory for 3.2 and older.

The patch must be backported as far as 3.0 with the commit above.
---

diff --git a/src/applet.c b/src/applet.c
index de555c325..51ed0f9d8 100644
--- a/src/applet.c
+++ b/src/applet.c
@@ -852,7 +852,7 @@ struct task *task_run_applet(struct task *t, void *context, unsigned int state)
 	/* Don't call I/O handler if the applet was shut (release callback was
 	 * already called)
 	 */
-	if (se_fl_test(app->sedesc, SE_FL_SHR | SE_FL_SHW))
+	if (!se_fl_test(app->sedesc, SE_FL_SHR | SE_FL_SHW))
 		app->applet->fct(app);
 
 	TRACE_POINT(APPLET_EV_PROCESS, app);