From: Greg Kroah-Hartman Date: Tue, 11 Dec 2018 13:11:06 +0000 (+0100) Subject: 4.4-stable patches X-Git-Tag: v4.19.9~11 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=abc6cd73c9258fca231673b3d5faa7a937c4431e;p=thirdparty%2Fkernel%2Fstable-queue.git 4.4-stable patches added patches: staging-lustre-remove-two-build-warnings.patch --- diff --git a/queue-4.4/series b/queue-4.4/series index 91bd78ef940..4964c3964aa 100644 --- a/queue-4.4/series +++ b/queue-4.4/series @@ -80,3 +80,4 @@ virtio-s390-fix-race-in-ccw_io_helper.patch sunrpc-fix-leak-of-krb5p-encode-pages.patch dmaengine-cppi41-delete-channel-from-pending-list-when-stop-channel.patch xhci-prevent-u1-u2-link-pm-states-if-exit-latency-is-too-long.patch +staging-lustre-remove-two-build-warnings.patch diff --git a/queue-4.4/staging-lustre-remove-two-build-warnings.patch b/queue-4.4/staging-lustre-remove-two-build-warnings.patch new file mode 100644 index 00000000000..7bcba7743bc --- /dev/null +++ b/queue-4.4/staging-lustre-remove-two-build-warnings.patch @@ -0,0 +1,46 @@ +From gregkh@linuxfoundation.org Tue Dec 11 14:07:57 2018 +From: Greg KH +Date: Tue, 11 Dec 2018 13:50:37 +0100 +Subject: Staging: lustre: remove two build warnings +To: linux-kernel@vger.kernel.org +Cc: stable@vger.kernel.org +Message-ID: <20181211125037.GA25594@kroah.com> +Content-Disposition: inline + +From: Greg Kroah-Hartman + +[for older kernels only, lustre has been removed from upstream] + +When someone writes: + strncpy(dest, source, sizeof(source)); +they really are just doing the same thing as: + strcpy(dest, source); +but somehow they feel better because they are now using the "safe" +version of the string functions. Cargo-cult programming at its +finest... + +gcc-8 rightfully warns you about doing foolish things like this. Now +that the stable kernels are all starting to be built using gcc-8, let's +get rid of this warning so that we do not have to gaze at this horror. + +To dropt the warning, just convert the code to using strcpy() so that if +someone really wants to audit this code and find all of the obvious +problems, it will be easier to do so. + +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/staging/lustre/lustre/lmv/lmv_obd.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c ++++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c +@@ -700,7 +700,7 @@ repeat_fid2path: + memmove(ptr + strlen(gf->gf_path) + 1, ptr, + strlen(ori_gf->gf_path)); + +- strncpy(ptr, gf->gf_path, strlen(gf->gf_path)); ++ strcpy(ptr, gf->gf_path); + ptr += strlen(gf->gf_path); + *ptr = '/'; + }