From: Corvin Köhne <corvin.koehne@gmail.com>
Date: Wed, 28 Aug 2024 13:43:23 +0000 (+0200)
Subject: vfio/igd: support legacy mode for all known generations
X-Git-Tag: v9.2.0-rc0~83^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=abd9dda914eac1fdcf21ce9b3ddd79ebe0172db2;p=thirdparty%2Fqemu.git

vfio/igd: support legacy mode for all known generations

We're soon going to add support for legacy mode to ElkhartLake and
TigerLake devices. Those are gen 11 and 12 devices. At the moment, all
devices identified by our igd_gen function do support legacy mode. This
won't change when adding our new devices of gen 11 and 12. Therefore, it
makes more sense to accept legacy mode for all known devices instead of
maintaining a long list of known good generations. If we add a new
generation to igd_gen which doesn't support legacy mode for some reason,
it'll be easy to advance the check to reject legacy mode for this
specific generation.

Signed-off-by: Corvin Köhne <c.koehne@beckhoff.com>
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
---

diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
index 650a323ddaa..d5e57656a8b 100644
--- a/hw/vfio/igd.c
+++ b/hw/vfio/igd.c
@@ -416,7 +416,7 @@ void vfio_probe_igd_bar4_quirk(VFIOPCIDevice *vdev, int nr)
      * devices maintain compatibility with generation 8.
      */
     gen = igd_gen(vdev);
-    if (gen != 6 && gen != 8) {
+    if (gen == -1) {
         error_report("IGD device %s is unsupported in legacy mode, "
                      "try SandyBridge or newer", vdev->vbasedev.name);
         return;