From: Paolo Bonzini <pbonzini@redhat.com>
Date: Wed, 4 Dec 2024 15:40:29 +0000 (+0100)
Subject: rust: pl011: match break logic of C version
X-Git-Tag: v10.0.0-rc0~111^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ac096b0bef98a79fafb1254fef121a175c9b73fc;p=thirdparty%2Fqemu.git

rust: pl011: match break logic of C version

Check loopback_enabled(), not fifo_enabled(), like the C code.

Also, set_break_error() must not happen until the break is read from
the FIFO.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src/device.rs
index e85d13c5a2b..960ee38ed69 100644
--- a/rust/hw/char/pl011/src/device.rs
+++ b/rust/hw/char/pl011/src/device.rs
@@ -460,9 +460,8 @@ impl PL011State {
     }
 
     pub fn event(&mut self, event: QEMUChrEvent) {
-        if event == bindings::QEMUChrEvent::CHR_EVENT_BREAK && !self.fifo_enabled() {
+        if event == bindings::QEMUChrEvent::CHR_EVENT_BREAK && !self.loopback_enabled() {
             self.put_fifo(DATA_BREAK);
-            self.receive_status_error_clear.set_break_error(true);
         }
     }