From: Martin Jocic Date: Fri, 14 Jun 2024 15:15:19 +0000 (+0200) Subject: can: kvaser_pciefd: Skip redundant NULL pointer check in ISR X-Git-Tag: v6.11-rc1~163^2~151^2~3^2~5 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ac765219c2c4e44f29063724c8d36435a3e61985;p=thirdparty%2Fkernel%2Flinux.git can: kvaser_pciefd: Skip redundant NULL pointer check in ISR This check is already done at the creation of the net devices in kvaser_pciefd_setup_can_ctrls called from kvaser_pciefd_probe. If it fails, the driver won't load, so there should be no need to repeat the check inside the ISR. The number of channels is read from the FPGA and should be trusted. Signed-off-by: Martin Jocic Link: https://lore.kernel.org/all/20240614151524.2718287-3-martin.jocic@kvaser.com Signed-off-by: Marc Kleine-Budde --- diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c index fa205091aafef..4832a93d34de5 100644 --- a/drivers/net/can/kvaser_pciefd.c +++ b/drivers/net/can/kvaser_pciefd.c @@ -1701,12 +1701,6 @@ static irqreturn_t kvaser_pciefd_irq_handler(int irq, void *dev) kvaser_pciefd_receive_irq(pcie); for (i = 0; i < pcie->nr_channels; i++) { - if (!pcie->can[i]) { - dev_err(&pcie->pci->dev, - "IRQ mask points to unallocated controller\n"); - break; - } - /* Check that mask matches channel (i) IRQ mask */ if (board_irq & irq_mask->kcan_tx[i]) kvaser_pciefd_transmit_irq(pcie->can[i]);