From: Codrin Ciubotariu Date: Mon, 16 Sep 2024 13:19:10 +0000 (+0300) Subject: ASoC: atmel: atmel_ssc_dai: Drop S24_LE support due to single channel limitation X-Git-Tag: v6.13-rc1~123^2~2^2~125^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ac8775d7de5a8ccac225a398cbce9fb9fffdbb9f;p=thirdparty%2Flinux.git ASoC: atmel: atmel_ssc_dai: Drop S24_LE support due to single channel limitation Drop S24_LE format because it is not supported if more than 2 channels (of TDM slots) are used. This limitation makes it impractical for use cases requiring more than 2 TDM slots, leading to potential issues in multi-channel configurations. [andrei.simion@microchip.com: Reword the commit title and the commit message. Add code comment to explain the removed code.] Signed-off-by: Codrin Ciubotariu Signed-off-by: Andrei Simion Reviewed-by: Alexandre Belloni Link: https://patch.msgid.link/20240916131910.22680-3-andrei.simion@microchip.com Signed-off-by: Mark Brown --- diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c index 7047f17fe7a89..89098f41679c0 100644 --- a/sound/soc/atmel/atmel_ssc_dai.c +++ b/sound/soc/atmel/atmel_ssc_dai.c @@ -821,8 +821,9 @@ static int atmel_ssc_resume(struct snd_soc_component *component) return 0; } +/* S24_LE is not supported if more than 2 channels (of TDM slots) are used. */ #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE |\ - SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) + SNDRV_PCM_FMTBIT_S32_LE) static const struct snd_soc_dai_ops atmel_ssc_dai_ops = { .startup = atmel_ssc_startup,