From: Willy Tarreau <w@1wt.eu>
Date: Wed, 1 Oct 2014 18:50:17 +0000 (+0200)
Subject: BUG/MINOR: config: don't propagate process binding on fatal errors.
X-Git-Tag: v1.6-dev1~304
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=acbe8ab38a638a076f8cf9fe2635db0e729d6a1f;p=thirdparty%2Fhaproxy.git

BUG/MINOR: config: don't propagate process binding on fatal errors.

propagate_processes() must not be called with unresolved proxies, but
nothing prevents it from being called in check_config_validity(). The
resulting effect is that an unresolved proxy can cause a recursion
loop if called in such a situation, ending with a segfault after the
fatal error report. There's no side effect beyond this.

This patch refrains from calling the function when any error was met.

This bug also affects 1.5, it should be backported.
---

diff --git a/src/cfgparse.c b/src/cfgparse.c
index 133ef601e7..a5af90b24a 100644
--- a/src/cfgparse.c
+++ b/src/cfgparse.c
@@ -7246,10 +7246,14 @@ out_uri_auth_compat:
 			global.stats_fe->bind_proc = ~0UL;
 	}
 
-	/* propagate bindings from frontends to backends */
-	for (curproxy = proxy; curproxy; curproxy = curproxy->next) {
-		if (curproxy->cap & PR_CAP_FE)
-			propagate_processes(curproxy, NULL);
+	/* propagate bindings from frontends to backends. Don't do it if there
+	 * are any fatal errors as we must not call it with unresolved proxies.
+	 */
+	if (!cfgerr) {
+		for (curproxy = proxy; curproxy; curproxy = curproxy->next) {
+			if (curproxy->cap & PR_CAP_FE)
+				propagate_processes(curproxy, NULL);
+		}
 	}
 
 	/* Bind each unbound backend to all processes when not specified. */