From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Mon, 20 Sep 2021 09:18:24 +0000 (+0200)
Subject: MINOR: quic: Add useful trace about pktns discarding
X-Git-Tag: v2.5-dev8~32
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=acd43a597c04fbdf32db9a46b86664cbb87bf344;p=thirdparty%2Fhaproxy.git

MINOR: quic: Add useful trace about pktns discarding

It is important to know if the packet number spaces used during the
handshakes have really been discarding. If not, this may have a
significant impact on the packet loss detection.
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index 75ba788dae..2d79d9a2f4 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -2160,6 +2160,7 @@ static int qc_prep_hdshk_pkts(struct qring *qr, struct ssl_sock_ctx *ctx)
 			if (HA_ATOMIC_LOAD(&qc->state) == QUIC_HS_ST_CLIENT_INITIAL &&
 			    pkt_type == QUIC_PACKET_TYPE_HANDSHAKE) {
 				quic_tls_discard_keys(&qc->els[QUIC_TLS_ENC_LEVEL_INITIAL]);
+				TRACE_PROTO("discarding Initial pktns", QUIC_EV_CONN_PHPKTS, ctx->conn);
 				quic_pktns_discard(qc->els[QUIC_TLS_ENC_LEVEL_INITIAL].pktns, qc);
 				qc_set_timer(ctx);
 				HA_ATOMIC_STORE(&qc->state, QUIC_HS_ST_CLIENT_HANDSHAKE);
@@ -2739,6 +2740,7 @@ struct task *quic_conn_io_cb(struct task *t, void *context, unsigned int state)
 	    (prev_st == QUIC_HS_ST_SERVER_INITIAL || prev_st == QUIC_HS_ST_SERVER_HANDSHAKE)) {
 		/* Discard the Handshake keys. */
 		quic_tls_discard_keys(&qc->els[QUIC_TLS_ENC_LEVEL_HANDSHAKE]);
+		TRACE_PROTO("discarding Handshake pktns", QUIC_EV_CONN_PHPKTS, ctx->conn);
 		quic_pktns_discard(qc->els[QUIC_TLS_ENC_LEVEL_HANDSHAKE].pktns, qc);
 		qc_set_timer(ctx);
 		if (!quic_build_post_handshake_frames(qc))