From: Christoph Hellwig Date: Tue, 27 Aug 2024 06:50:45 +0000 (+0200) Subject: block: remove checks for FALLOC_FL_NO_HIDE_STALE X-Git-Tag: v6.12-rc1~212^2^2~5 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ad01dadaa9dc1e8aed1aa372d2a030407835137f;p=thirdparty%2Fkernel%2Flinux.git block: remove checks for FALLOC_FL_NO_HIDE_STALE While the FALLOC_FL_NO_HIDE_STALE value has been registered, it has always been rejected by vfs_fallocate before making it into blkdev_fallocate because it isn't in the supported mask. Signed-off-by: Christoph Hellwig Link: https://lore.kernel.org/r/20240827065123.1762168-2-hch@lst.de Reviewed-by: Darrick J. Wong Reviewed-by: Jan Kara Signed-off-by: Christian Brauner --- diff --git a/block/fops.c b/block/fops.c index 9825c1713a49a..7f48f03a62e9a 100644 --- a/block/fops.c +++ b/block/fops.c @@ -771,7 +771,7 @@ reexpand: #define BLKDEV_FALLOC_FL_SUPPORTED \ (FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | \ - FALLOC_FL_ZERO_RANGE | FALLOC_FL_NO_HIDE_STALE) + FALLOC_FL_ZERO_RANGE) static long blkdev_fallocate(struct file *file, int mode, loff_t start, loff_t len) @@ -830,14 +830,6 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start, len >> SECTOR_SHIFT, GFP_KERNEL, BLKDEV_ZERO_NOFALLBACK); break; - case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HIDE_STALE: - error = truncate_bdev_range(bdev, file_to_blk_mode(file), start, end); - if (error) - goto fail; - - error = blkdev_issue_discard(bdev, start >> SECTOR_SHIFT, - len >> SECTOR_SHIFT, GFP_KERNEL); - break; default: error = -EOPNOTSUPP; }