From: Stefan Schantl <stefan.schantl@ipfire.org>
Date: Fri, 22 Mar 2024 05:01:45 +0000 (+0100)
Subject: ids.cgi: Improve add provider logic
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ad0d064a487c8912cbe4bd77ae652a4212e0fae9;p=people%2Fms%2Fipfire-2.x.git

ids.cgi: Improve add provider logic

Do not longer add unsupported/removed providers as an option
when adding a new/first ruleset provider.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/html/cgi-bin/ids.cgi b/html/cgi-bin/ids.cgi
index 2d4ac6fc3..edab97195 100644
--- a/html/cgi-bin/ids.cgi
+++ b/html/cgi-bin/ids.cgi
@@ -1711,6 +1711,12 @@ END
 							# Grab the provider handle.
 							my $provider = $tmphash{$provider_name};
 
+							# Check if we are not in edit mode.
+							if ($cgiparams{'PROVIDERS'} ne "$Lang::tr{'edit'}") {
+								# Skip unsupported ruleset provider.
+								next unless(exists($IDS::Ruleset::Providers{$provider}{"dl_url"}));
+							}
+
 							# Pre-select the provider if one is given.
 							if (($used_providers{$cgiparams{'ID'}}[0] eq "$provider") || ($cgiparams{'PROVIDER'} eq "$provider")) {
 								$selected{$provider} = "selected='selected'";