From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Wed, 15 Apr 2020 12:04:04 +0000 (+0200)
Subject: log: restore non-local value
X-Git-Tag: lxc-5.0.0~451^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ad9ea93929ca5a9e99ff44d8da1de602356fa67d;p=thirdparty%2Flxc.git

log: restore non-local value

Fixes: Coverity 1461734.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/log.c b/src/lxc/log.c
index 30d6773f6..1dd277d96 100644
--- a/src/lxc/log.c
+++ b/src/lxc/log.c
@@ -485,10 +485,9 @@ static int build_dir(const char *name)
 		*p = '\0';
 
 		ret = lxc_unpriv(mkdir(n, 0755));
+		*p = '/';
 		if (ret && errno != EEXIST)
 			return log_error_errno(-errno, errno, "Failed to create directory \"%s\"", n);
-
-		*p = '/';
 	}
 
 	return 0;