From: Stefan Schantl Date: Mon, 18 May 2020 19:15:54 +0000 (+0200) Subject: ids-functions.pl: Fix generating of HOME_NET declaration X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=adb320bc4a834db81137c3b9b8c2158e54f0a615;p=people%2Fstevee%2Fipfire-2.x.git ids-functions.pl: Fix generating of HOME_NET declaration Fixes #12407. Signed-off-by: Stefan Schantl Signed-off-by: Arne Fitzenreiter --- diff --git a/config/cfgroot/ids-functions.pl b/config/cfgroot/ids-functions.pl index f124b12be6..e335698499 100644 --- a/config/cfgroot/ids-functions.pl +++ b/config/cfgroot/ids-functions.pl @@ -677,22 +677,7 @@ sub generate_home_net_file() { } # Format home net declaration. - my $line = "\"\["; - - # Loop through the array of networks. - foreach my $network (@networks) { - # Add the network to the line. - $line = "$line" . "$network"; - - # Check if the current network was the last in the array. - if ($network eq $networks[-1]) { - # Close the line. - $line = "$line" . "\]\""; - } else { - # Add "," for the next network. - $line = "$line" . "\,"; - } - } + my $line = "[" . join(',', @networks) . "]"; # Open file to store the addresses of the home net. open(FILE, ">$homenet_file") or die "Could not open $homenet_file. $!\n";