From: Bernd Edlinger <bernd.edlinger@hotmail.de>
Date: Fri, 12 Apr 2024 06:55:11 +0000 (+0200)
Subject: sim: riscv: Fix PC at gdb breakpoints
X-Git-Tag: gdb-15-branchpoint~413
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ae14cde6fd2c527c407a115fa1684c2002749552;p=thirdparty%2Fbinutils-gdb.git

sim: riscv: Fix PC at gdb breakpoints

The uncompressed EBREAK instruction does not work
correctly this way, and the comment saying that
GDB expects us to step over EBREAK is just wrong.
The PC was always 4 bytes too high, which skips one
instruction at break and step over commands, and
causes complete chaos.  The compressed EBREAK was
already implemented correctly.

Tested by using gdb's "target sim" and single-stepping.

Approved-By: Andrew Burgess <aburgess@redhat.com>
---

diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c
index adff99921c6..ddc7e1d3e98 100644
--- a/sim/riscv/sim-main.c
+++ b/sim/riscv/sim-main.c
@@ -623,9 +623,7 @@ execute_i (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op)
       break;
     case MATCH_EBREAK:
       TRACE_INSN (cpu, "ebreak;");
-      /* GDB expects us to step over EBREAK.  */
-      sim_engine_halt (sd, cpu, NULL, riscv_cpu->pc + 4, sim_stopped,
-		       SIM_SIGTRAP);
+      sim_engine_halt (sd, cpu, NULL, riscv_cpu->pc, sim_stopped, SIM_SIGTRAP);
       break;
     case MATCH_ECALL:
       TRACE_INSN (cpu, "ecall;");