From: Ævar Arnfjörð Bjarmason Date: Wed, 31 Aug 2022 23:14:17 +0000 (+0200) Subject: submodule--helper: fix a memory leak in get_default_remote_submodule() X-Git-Tag: v2.38.0-rc0~7^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ae3ef94d9bc61931636647c4eab558e09aaeb50a;p=thirdparty%2Fgit.git submodule--helper: fix a memory leak in get_default_remote_submodule() Fix a memory leak in the get_default_remote_submodule() function added in a77c3fcb5ec (submodule--helper: get remote names from any repository, 2022-03-04), we need to repo_clear() the submodule we initialize. Signed-off-by: Ævar Arnfjörð Bjarmason Reviewed-by: Glen Choo Signed-off-by: Junio C Hamano --- diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 79ffcb5090..8866af2250 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -65,12 +65,16 @@ static int repo_get_default_remote(struct repository *repo, char **default_remot static int get_default_remote_submodule(const char *module_path, char **default_remote) { struct repository subrepo; + int ret; if (repo_submodule_init(&subrepo, the_repository, module_path, null_oid()) < 0) return die_message(_("could not get a repository handle for submodule '%s'"), module_path); - return repo_get_default_remote(&subrepo, default_remote); + ret = repo_get_default_remote(&subrepo, default_remote); + repo_clear(&subrepo); + + return ret; } static char *get_default_remote(void)