From: Christoph Hellwig Date: Mon, 29 Jul 2024 23:22:55 +0000 (-0700) Subject: xfs: don't open code XFS_FILBLKS_MIN in xfs_bmapi_write X-Git-Tag: v6.10.0~24^2~18 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ae85a9c8c190ea0ab48ee9777c5df91b4449d25d;p=thirdparty%2Fxfsprogs-dev.git xfs: don't open code XFS_FILBLKS_MIN in xfs_bmapi_write Source kernel commit: 9d06960341ec5f45d3d65bdead3fbce753455e8a XFS_FILBLKS_MIN uses min_t and thus does the comparison using the correct xfs_filblks_t type. Use it in xfs_bmapi_write and slightly adjust the comment document th potential pitfall to take account of this Signed-off-by: Christoph Hellwig Reviewed-by: "Darrick J. Wong" Signed-off-by: Chandan Babu R --- diff --git a/libxfs/xfs_bmap.c b/libxfs/xfs_bmap.c index 5b1c305e..87f0a285 100644 --- a/libxfs/xfs_bmap.c +++ b/libxfs/xfs_bmap.c @@ -4522,14 +4522,11 @@ xfs_bmapi_write( * allocation length request (which can be 64 bits in * length) and the bma length request, which is * xfs_extlen_t and therefore 32 bits. Hence we have to - * check for 32-bit overflows and handle them here. + * be careful and do the min() using the larger type to + * avoid overflows. */ - if (len > (xfs_filblks_t)XFS_MAX_BMBT_EXTLEN) - bma.length = XFS_MAX_BMBT_EXTLEN; - else - bma.length = len; + bma.length = XFS_FILBLKS_MIN(len, XFS_MAX_BMBT_EXTLEN); - ASSERT(len > 0); ASSERT(bma.length > 0); error = xfs_bmapi_allocate(&bma); if (error) {