From: Amos Jeffries <squid3@treenet.co.nz>
Date: Tue, 24 May 2011 05:33:47 +0000 (+1200)
Subject: Docs: fancy up ERR_INVALID_REQ with some javascript
X-Git-Tag: take07~16^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ae8d89c960cd5468c24d8a905d3a787e1849d9c4;p=thirdparty%2Fsquid.git

Docs: fancy up ERR_INVALID_REQ with some javascript

Some of the "possible problems" can be determined as not-relevant.
When these cases are detected hide the text from viewers in a way that
keeps the page operational when javascript is disabled.
---

diff --git a/errors/templates/ERR_INVALID_REQ b/errors/templates/ERR_INVALID_REQ
index 7ec7e9179b..ea0482c16f 100644
--- a/errors/templates/ERR_INVALID_REQ
+++ b/errors/templates/ERR_INVALID_REQ
@@ -25,9 +25,9 @@ body
 
 <p>Some possible problems are:</p>
 <ul>
-<li><p>Missing or unknown request method.</p></li>
-<li><p>Missing URL.</p></li>
-<li><p>Missing HTTP Identifier (HTTP/1.0).</p></li>
+<li id="missing-method"><p>Missing or unknown request method.</p></li>
+<li id="missing-url"><p>Missing URL.</p></li>
+<li id="missing-protocol"><p>Missing HTTP Identifier (HTTP/1.0).</p></li>
 <li><p>Request is too large.</p></li>
 <li><p>Content-Length missing for POST or PUT requests.</p></li>
 <li><p>Illegal character in hostname; underscores are not allowed.</p></li>
@@ -38,6 +38,12 @@ body
 <br>
 </div>
 
+<script language="javascript">
+if ('%M' != '[unknown method]') document.getElementById('missing-method').style.display = 'none';
+if ('%u' != '[no URL]') document.getElementById('missing-url').style.display = 'none';
+if ('%P' != '[unknown protocol]') document.getElementById('missing-protocol').style.display = 'none';
+</script>
+
 <hr>
 <div id="footer">
 <p>Generated %T by %h (%s)</p>