From: Jiapeng Chong Date: Tue, 1 Jun 2021 11:07:49 +0000 (+0800) Subject: RDMA/cxgb4: Fix missing error code in create_qp() X-Git-Tag: v5.14-rc1~112^2~121 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=aeb27bb76ad8197eb47890b1ff470d5faf8ec9a5;p=thirdparty%2Fkernel%2Flinux.git RDMA/cxgb4: Fix missing error code in create_qp() The error code is missing in this code scenario so 0 will be returned. Add the error code '-EINVAL' to the return value 'ret'. Eliminates the follow smatch warning: drivers/infiniband/hw/cxgb4/qp.c:298 create_qp() warn: missing error code 'ret'. Link: https://lore.kernel.org/r/1622545669-20625-1-git-send-email-jiapeng.chong@linux.alibaba.com Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c index 1b078d5e321f9..a81fa7a56edb7 100644 --- a/drivers/infiniband/hw/cxgb4/qp.c +++ b/drivers/infiniband/hw/cxgb4/qp.c @@ -295,6 +295,7 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq, if (user && (!wq->sq.bar2_pa || (need_rq && !wq->rq.bar2_pa))) { pr_warn("%s: sqid %u or rqid %u not in BAR2 range\n", pci_name(rdev->lldi.pdev), wq->sq.qid, wq->rq.qid); + ret = -EINVAL; goto free_dma; }