From: Alejandro Colomar <alx@kernel.org>
Date: Fri, 21 Feb 2025 05:25:15 +0000 (+0100)
Subject: tests/unit/: Unname unused parameters in callbacks
X-Git-Tag: 4.19.0-rc1~53
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=aee5c0f4f0dbe89002a3e875a41a819538d1086e;p=thirdparty%2Fshadow.git

tests/unit/: Unname unused parameters in callbacks

This silences diagnostics about unused parameters.

Tested-by: Silvan Mosberger <github@infinisil.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/tests/unit/test_adds.c b/tests/unit/test_adds.c
index fdc671f5c..913a179df 100644
--- a/tests/unit/test_adds.c
+++ b/tests/unit/test_adds.c
@@ -13,13 +13,13 @@
 #include "adds.h"
 
 
-static void test_addsl_2_ok(void **state);
-static void test_addsl_2_underflow(void **state);
-static void test_addsl_2_overflow(void **state);
-static void test_addsl_3_ok(void **state);
-static void test_addsl_3_underflow(void **state);
-static void test_addsl_3_overflow(void **state);
-static void test_addsl_5_ok(void **state);
+static void test_addsl_2_ok(void **);
+static void test_addsl_2_underflow(void **);
+static void test_addsl_2_overflow(void **);
+static void test_addsl_3_ok(void **);
+static void test_addsl_3_underflow(void **);
+static void test_addsl_3_overflow(void **);
+static void test_addsl_5_ok(void **);
 
 
 int
@@ -40,7 +40,7 @@ main(void)
 
 
 static void
-test_addsl_2_ok(void **state)
+test_addsl_2_ok(void **)
 {
 	assert_true(addsl(1, 3)			== 1 + 3);
 	assert_true(addsl(-4321, 7)		== -4321 + 7);
@@ -54,7 +54,7 @@ test_addsl_2_ok(void **state)
 
 
 static void
-test_addsl_2_underflow(void **state)
+test_addsl_2_underflow(void **)
 {
 	assert_true(addsl(LONG_MIN, -1)		== LONG_MIN);
 	assert_true(addsl(LONG_MIN + 3, -7)	== LONG_MIN);
@@ -63,7 +63,7 @@ test_addsl_2_underflow(void **state)
 
 
 static void
-test_addsl_2_overflow(void **state)
+test_addsl_2_overflow(void **)
 {
 	assert_true(addsl(LONG_MAX, 1)		== LONG_MAX);
 	assert_true(addsl(LONG_MAX - 3, 7)	== LONG_MAX);
@@ -72,7 +72,7 @@ test_addsl_2_overflow(void **state)
 
 
 static void
-test_addsl_3_ok(void **state)
+test_addsl_3_ok(void **)
 {
 	assert_true(addsl(1, 2, 3)		== 1 + 2 + 3);
 	assert_true(addsl(LONG_MIN, -3, 4)	== LONG_MIN + 4 - 3);
@@ -82,7 +82,7 @@ test_addsl_3_ok(void **state)
 
 
 static void
-test_addsl_3_underflow(void **state)
+test_addsl_3_underflow(void **)
 {
 	assert_true(addsl(LONG_MIN, 2, -3)	== LONG_MIN);
 	assert_true(addsl(LONG_MIN, -1, 0)	== LONG_MIN);
@@ -90,7 +90,7 @@ test_addsl_3_underflow(void **state)
 
 
 static void
-test_addsl_3_overflow(void **state)
+test_addsl_3_overflow(void **)
 {
 	assert_true(addsl(LONG_MAX, -1, 2)	== LONG_MAX);
 	assert_true(addsl(LONG_MAX, +1, 0)	== LONG_MAX);
@@ -99,7 +99,7 @@ test_addsl_3_overflow(void **state)
 
 
 static void
-test_addsl_5_ok(void **state)
+test_addsl_5_ok(void **)
 {
 	assert_true(addsl(LONG_MAX, LONG_MAX, LONG_MIN, LONG_MIN, 44) == 42);
 }
diff --git a/tests/unit/test_atoi_strtoi.c b/tests/unit/test_atoi_strtoi.c
index 782c8a4c6..3947745b0 100644
--- a/tests/unit/test_atoi_strtoi.c
+++ b/tests/unit/test_atoi_strtoi.c
@@ -18,9 +18,9 @@
 #include "atoi/strtoi/strtou_noneg.h"
 
 
-static void test_strtoi(void **state);
-static void test_strtou(void **state);
-static void test_strtou_noneg(void **state);
+static void test_strtoi(void **);
+static void test_strtou(void **);
+static void test_strtou_noneg(void **);
 
 
 int
@@ -37,7 +37,7 @@ main(void)
 
 
 static void
-test_strtoi(void **state)
+test_strtoi(void **)
 {
 	int   status;
 	char  *end;
@@ -78,7 +78,7 @@ test_strtoi(void **state)
 
 
 static void
-test_strtou(void **state)
+test_strtou(void **)
 {
 	int   status;
 	char  *end;
@@ -119,7 +119,7 @@ test_strtou(void **state)
 
 
 static void
-test_strtou_noneg(void **state)
+test_strtou_noneg(void **)
 {
 	int   status;
 	char  *end;
diff --git a/tests/unit/test_chkname.c b/tests/unit/test_chkname.c
index 3f190a773..e22781207 100644
--- a/tests/unit/test_chkname.c
+++ b/tests/unit/test_chkname.c
@@ -20,15 +20,15 @@
 #include "chkname.h"
 
 
-static void test_is_valid_user_name_ok(void **state);
-static void test_is_valid_user_name_ok_dollar(void **state);
-static void test_is_valid_user_name_nok_dash(void **state);
-static void test_is_valid_user_name_nok_dir(void **state);
-static void test_is_valid_user_name_nok_dollar(void **state);
-static void test_is_valid_user_name_nok_empty(void **state);
-static void test_is_valid_user_name_nok_numeric(void **state);
-static void test_is_valid_user_name_nok_otherchars(void **state);
-static void test_is_valid_user_name_long(void **state);
+static void test_is_valid_user_name_ok(void **);
+static void test_is_valid_user_name_ok_dollar(void **);
+static void test_is_valid_user_name_nok_dash(void **);
+static void test_is_valid_user_name_nok_dir(void **);
+static void test_is_valid_user_name_nok_dollar(void **);
+static void test_is_valid_user_name_nok_empty(void **);
+static void test_is_valid_user_name_nok_numeric(void **);
+static void test_is_valid_user_name_nok_otherchars(void **);
+static void test_is_valid_user_name_long(void **);
 
 
 int
@@ -51,7 +51,7 @@ main(void)
 
 
 static void
-test_is_valid_user_name_ok(void **state)
+test_is_valid_user_name_ok(void **)
 {
 	assert_true(is_valid_user_name("alx"));
 	assert_true(is_valid_user_name("u-ser"));
@@ -66,7 +66,7 @@ test_is_valid_user_name_ok(void **state)
 
 
 static void
-test_is_valid_user_name_ok_dollar(void **state)
+test_is_valid_user_name_ok_dollar(void **)
 {
 	// Non-POSIX extension for Samba 3.x "add machine script".
 	assert_true(is_valid_user_name("dollar$"));
@@ -75,7 +75,7 @@ test_is_valid_user_name_ok_dollar(void **state)
 
 
 static void
-test_is_valid_user_name_nok_dash(void **state)
+test_is_valid_user_name_nok_dash(void **)
 {
 	assert_true(false == is_valid_user_name("-"));
 	assert_true(false == is_valid_user_name("-not-valid"));
@@ -84,7 +84,7 @@ test_is_valid_user_name_nok_dash(void **state)
 
 
 static void
-test_is_valid_user_name_nok_dir(void **state)
+test_is_valid_user_name_nok_dir(void **)
 {
 	assert_true(false == is_valid_user_name("."));
 	assert_true(false == is_valid_user_name(".."));
@@ -92,7 +92,7 @@ test_is_valid_user_name_nok_dir(void **state)
 
 
 static void
-test_is_valid_user_name_nok_dollar(void **state)
+test_is_valid_user_name_nok_dollar(void **)
 {
 	assert_true(false == is_valid_user_name("$"));
 	assert_true(false == is_valid_user_name("$dollar"));
@@ -103,14 +103,14 @@ test_is_valid_user_name_nok_dollar(void **state)
 
 
 static void
-test_is_valid_user_name_nok_empty(void **state)
+test_is_valid_user_name_nok_empty(void **)
 {
 	assert_true(false == is_valid_user_name(""));
 }
 
 
 static void
-test_is_valid_user_name_nok_numeric(void **state)
+test_is_valid_user_name_nok_numeric(void **)
 {
 	assert_true(false == is_valid_user_name("6"));
 	assert_true(false == is_valid_user_name("42"));
@@ -118,7 +118,7 @@ test_is_valid_user_name_nok_numeric(void **state)
 
 
 static void
-test_is_valid_user_name_nok_otherchars(void **state)
+test_is_valid_user_name_nok_otherchars(void **)
 {
 	assert_true(false == is_valid_user_name("no spaces"));
 	assert_true(false == is_valid_user_name("no,"));
@@ -128,7 +128,7 @@ test_is_valid_user_name_nok_otherchars(void **state)
 
 
 static void
-test_is_valid_user_name_long(void **state)
+test_is_valid_user_name_long(void **)
 {
 	size_t  max;
 	char    *name;
diff --git a/tests/unit/test_exit_if_null.c b/tests/unit/test_exit_if_null.c
index ce6b89858..392a7f47a 100644
--- a/tests/unit/test_exit_if_null.c
+++ b/tests/unit/test_exit_if_null.c
@@ -26,10 +26,10 @@
 static jmp_buf  jmpb;
 
 
-void __wrap_exit(int status);
+void __wrap_exit(int);
 
-static void test_exit_if_null_exit(void **state);
-static void test_exit_if_null_ok(void **state);
+static void test_exit_if_null_exit(void **);
+static void test_exit_if_null_ok(void **);
 
 
 int
@@ -45,14 +45,14 @@ main(void)
 
 
 void
-__wrap_exit(int status)
+__wrap_exit(int)
 {
 	longjmp(jmpb, EXIT_CALLED);
 }
 
 
 static void
-test_exit_if_null_exit(void **state)
+test_exit_if_null_exit(void **)
 {
 	char *volatile  p;
 
@@ -78,7 +78,7 @@ test_exit_if_null_exit(void **state)
 
 
 static void
-test_exit_if_null_ok(void **state)
+test_exit_if_null_ok(void **)
 {
 	char  *p;
 
diff --git a/tests/unit/test_logind.c b/tests/unit/test_logind.c
index f91782ce7..4f5cf7576 100644
--- a/tests/unit/test_logind.c
+++ b/tests/unit/test_logind.c
@@ -33,7 +33,7 @@ __wrap_sd_uid_get_sessions(uid_t uid, int require_active, char ***sessions)
 /***********************
  * TEST
  **********************/
-static void test_active_sessions_count_return_ok(void **state)
+static void test_active_sessions_count_return_ok(void **)
 {
     int count;
     struct passwd *pw = malloc(sizeof(struct passwd));
@@ -46,7 +46,7 @@ static void test_active_sessions_count_return_ok(void **state)
     assert_int_equal(count, 1);
 }
 
-static void test_active_sessions_count_prefix_getpwnam_failure(void **state)
+static void test_active_sessions_count_prefix_getpwnam_failure(void **)
 {
     int count;
     struct passwd *pw = NULL;
diff --git a/tests/unit/test_snprintf.c b/tests/unit/test_snprintf.c
index f873de627..df7789143 100644
--- a/tests/unit/test_snprintf.c
+++ b/tests/unit/test_snprintf.c
@@ -17,8 +17,8 @@
 #include "string/sprintf/snprintf.h"
 
 
-static void test_stprintf_a_trunc(void **state);
-static void test_stprintf_a_ok(void **state);
+static void test_stprintf_a_trunc(void **);
+static void test_stprintf_a_ok(void **);
 
 
 int
@@ -34,7 +34,7 @@ main(void)
 
 
 static void
-test_stprintf_a_trunc(void **state)
+test_stprintf_a_trunc(void **)
 {
 	char  buf[countof("foo")];
 
@@ -48,7 +48,7 @@ test_stprintf_a_trunc(void **state)
 
 
 static void
-test_stprintf_a_ok(void **state)
+test_stprintf_a_ok(void **)
 {
 	char  buf[countof("foo")];
 
diff --git a/tests/unit/test_strncpy.c b/tests/unit/test_strncpy.c
index e5655920c..3da043154 100644
--- a/tests/unit/test_strncpy.c
+++ b/tests/unit/test_strncpy.c
@@ -18,9 +18,9 @@
 #include "string/strcpy/strncpy.h"
 
 
-static void test_strncpy_a_trunc(void **state);
-static void test_strncpy_a_fit(void **state);
-static void test_strncpy_a_pad(void **state);
+static void test_strncpy_a_trunc(void **);
+static void test_strncpy_a_fit(void **);
+static void test_strncpy_a_pad(void **);
 
 
 int
@@ -37,7 +37,7 @@ main(void)
 
 
 static void
-test_strncpy_a_trunc(void **state)
+test_strncpy_a_trunc(void **)
 {
 	char  buf[3];
 
@@ -52,7 +52,7 @@ test_strncpy_a_trunc(void **state)
 
 
 static void
-test_strncpy_a_fit(void **state)
+test_strncpy_a_fit(void **)
 {
 	char  buf[3];
 
@@ -67,7 +67,7 @@ test_strncpy_a_fit(void **state)
 
 
 static void
-test_strncpy_a_pad(void **state)
+test_strncpy_a_pad(void **)
 {
 	char  buf[3];
 
diff --git a/tests/unit/test_strtcpy.c b/tests/unit/test_strtcpy.c
index 5e292caaf..e4ce1572d 100644
--- a/tests/unit/test_strtcpy.c
+++ b/tests/unit/test_strtcpy.c
@@ -18,8 +18,8 @@
 #include "string/strcpy/strtcpy.h"
 
 
-static void test_strtcpy_a_trunc(void **state);
-static void test_strtcpy_a_ok(void **state);
+static void test_strtcpy_a_trunc(void **);
+static void test_strtcpy_a_ok(void **);
 
 
 int
@@ -35,7 +35,7 @@ main(void)
 
 
 static void
-test_strtcpy_a_trunc(void **state)
+test_strtcpy_a_trunc(void **)
 {
 	char  buf[countof("foo")];
 
@@ -49,7 +49,7 @@ test_strtcpy_a_trunc(void **state)
 
 
 static void
-test_strtcpy_a_ok(void **state)
+test_strtcpy_a_ok(void **)
 {
 	char  buf[countof("foo")];
 
diff --git a/tests/unit/test_typetraits.c b/tests/unit/test_typetraits.c
index 8ce04624a..d1e6ebc34 100644
--- a/tests/unit/test_typetraits.c
+++ b/tests/unit/test_typetraits.c
@@ -13,8 +13,8 @@
 #include "typetraits.h"
 
 
-static void test_type_max(void **state);
-static void test_type_min(void **state);
+static void test_type_max(void **);
+static void test_type_min(void **);
 
 
 int
@@ -30,7 +30,7 @@ main(void)
 
 
 static void
-test_type_max(void **state)
+test_type_max(void **)
 {
 	assert_true(type_max(long) == LONG_MAX);
 	assert_true(type_max(unsigned long) == ULONG_MAX);
@@ -43,7 +43,7 @@ test_type_max(void **state)
 
 
 static void
-test_type_min(void **state)
+test_type_min(void **)
 {
 	assert_true(type_min(long) == LONG_MIN);
 	assert_true(type_min(unsigned long) == 0);