From: Jiri Denemark <jdenemar@redhat.com>
Date: Fri, 3 Jun 2011 14:33:25 +0000 (+0200)
Subject: qemu: Avoid use after free in qemuCaps parsing
X-Git-Tag: v0.9.2~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=aeed51f77565c8cf3432104db8a9a942630fc580;p=thirdparty%2Flibvirt.git

qemu: Avoid use after free in qemuCaps parsing
---

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 46414cdae9..332c09e655 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -264,12 +264,13 @@ static int qemuDomainObjPrivateXMLParse(xmlXPathContextPtr ctxt, void *data)
             char *str = virXMLPropString(nodes[i], "name");
             if (str) {
                 int flag = qemuCapsTypeFromString(str);
-                VIR_FREE(str);
                 if (flag < 0) {
                     qemuReportError(VIR_ERR_INTERNAL_ERROR,
                                     _("Unknown qemu capabilities flag %s"), str);
+                    VIR_FREE(str);
                     goto error;
                 }
+                VIR_FREE(str);
                 qemuCapsSet(qemuCaps, flag);
             }
         }