From: Mateusz Guzik <mjguzik@gmail.com>
Date: Sun, 9 Feb 2025 18:55:21 +0000 (+0100)
Subject: vfs: catch invalid modes in may_open()
X-Git-Tag: v6.15-rc1~244^2~4^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=af153bb63a336a7ca0d9c8ef4ca98119c5020030;p=thirdparty%2Fkernel%2Flinux.git

vfs: catch invalid modes in may_open()

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Link: https://lore.kernel.org/r/20250209185523.745956-3-mjguzik@gmail.com
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
---

diff --git a/fs/namei.c b/fs/namei.c
index 3ab9440c5b931..21630a0f8e30a 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3415,6 +3415,8 @@ static int may_open(struct mnt_idmap *idmap, const struct path *path,
 		if ((acc_mode & MAY_EXEC) && path_noexec(path))
 			return -EACCES;
 		break;
+	default:
+		VFS_BUG_ON_INODE(1, inode);
 	}
 
 	error = inode_permission(idmap, inode, MAY_OPEN | acc_mode);