From: Nirmoy Das <nirmoy.das@amd.com>
Date: Thu, 2 Sep 2021 10:29:17 +0000 (+0200)
Subject: debugfs: debugfs_create_file_size(): use IS_ERR to check for error
X-Git-Tag: v5.15-rc4~6^2~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=af505cad9567f7a500d34bf183696d570d7f6810;p=thirdparty%2Flinux.git

debugfs: debugfs_create_file_size(): use IS_ERR to check for error

debugfs_create_file() returns encoded error so use IS_ERR for checking
return value.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
Fixes: ff9fb72bc077 ("debugfs: return error values, not NULL")
Cc: stable <stable@vger.kernel.org>
References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686
Link: https://lore.kernel.org/r/20210902102917.2233-1-nirmoy.das@amd.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index 8129a430d789d..2f117c57160dc 100644
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -528,7 +528,7 @@ void debugfs_create_file_size(const char *name, umode_t mode,
 {
 	struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
 
-	if (de)
+	if (!IS_ERR(de))
 		d_inode(de)->i_size = file_size;
 }
 EXPORT_SYMBOL_GPL(debugfs_create_file_size);