From: William Lallemand <wlallemand@haproxy.com>
Date: Fri, 2 May 2025 19:15:45 +0000 (+0200)
Subject: BUG/MINOR: acme/cli: don't output error on success
X-Git-Tag: v3.2-dev15~37
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=af5bbce66496d61499dec665a64738f7d0f52717;p=thirdparty%2Fhaproxy.git

BUG/MINOR: acme/cli: don't output error on success

Previous patch 7251c13c7 ("MINOR: acme: move the acme task init in a dedicated
function") mistakenly returned the wrong error code when "acme renew" parsing
was successful, and tried to emit an error message.

This patch fixes the issue by returning 0 when the acme task was correctly
scheduled to start.

No backport needed.
---

diff --git a/src/acme.c b/src/acme.c
index c2e37c130..098e2c593 100644
--- a/src/acme.c
+++ b/src/acme.c
@@ -2286,8 +2286,11 @@ static int cli_acme_renew_parse(char **args, char *payload, struct appctx *appct
 		goto err;
 	}
 
-	acme_start_task(store, &errmsg);
+	if (acme_start_task(store, &errmsg) != 0)
+		goto err;
 
+	HA_SPIN_UNLOCK(CKCH_LOCK, &ckch_lock);
+	return 0;
 err:
 	HA_SPIN_UNLOCK(CKCH_LOCK, &ckch_lock);
 	return cli_dynerr(appctx, errmsg);