From: Florent Xicluna <florent.xicluna@gmail.com>
Date: Sat, 6 Mar 2010 00:16:57 +0000 (+0000)
Subject: #2777: Apply same recipe for test_terminate and test_kill, i.e. close or redirect... 
X-Git-Tag: v2.7a4~20
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=af9a06a77fddfc304ecfcde8464bb995dfcdb25d;p=thirdparty%2FPython%2Fcpython.git

#2777: Apply same recipe for test_terminate and test_kill, i.e. close or redirect fds.
---

diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index 7437e6c3fb5c..cd378a231dfa 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -673,14 +673,16 @@ class POSIXProcessTestCase(unittest.TestCase):
         self.assertNotEqual(p.wait(), 0)
 
     def test_kill(self):
-        p = subprocess.Popen([sys.executable, "-c", "input()"])
+        p = subprocess.Popen([sys.executable, "-c", "input()"],
+                             stdin=subprocess.PIPE, close_fds=True)
 
         self.assertIsNone(p.poll())
         p.kill()
         self.assertEqual(p.wait(), -signal.SIGKILL)
 
     def test_terminate(self):
-        p = subprocess.Popen([sys.executable, "-c", "input()"])
+        p = subprocess.Popen([sys.executable, "-c", "input()"],
+                             stdin=subprocess.PIPE, close_fds=True)
 
         self.assertIsNone(p.poll())
         p.terminate()