From: Heiner Kallweit Date: Sat, 16 Dec 2023 20:05:33 +0000 (+0100) Subject: leds: trigger: panic: Don't register panic notifier if creating the trigger failed X-Git-Tag: v6.8-rc1~68^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=afacb21834bb02785ddb0c3ec197208803b74faa;p=thirdparty%2Fkernel%2Flinux.git leds: trigger: panic: Don't register panic notifier if creating the trigger failed It doesn't make sense to register the panic notifier if creating the panic trigger failed. Signed-off-by: Heiner Kallweit Link: https://lore.kernel.org/r/8a61e229-5388-46c7-919a-4d18cc7362b2@gmail.com Signed-off-by: Lee Jones --- diff --git a/drivers/leds/trigger/ledtrig-panic.c b/drivers/leds/trigger/ledtrig-panic.c index 64abf2e91608a..5a6b21bfeb9af 100644 --- a/drivers/leds/trigger/ledtrig-panic.c +++ b/drivers/leds/trigger/ledtrig-panic.c @@ -64,10 +64,13 @@ static long led_panic_blink(int state) static int __init ledtrig_panic_init(void) { + led_trigger_register_simple("panic", &trigger); + if (!trigger) + return -ENOMEM; + atomic_notifier_chain_register(&panic_notifier_list, &led_trigger_panic_nb); - led_trigger_register_simple("panic", &trigger); panic_blink = led_panic_blink; return 0; }