From: Jason A. Donenfeld <Jason@zx2c4.com>
Date: Sat, 12 Feb 2022 00:26:17 +0000 (+0100)
Subject: random: do not take pool spinlock at boot
X-Git-Tag: v5.18-rc1~200^2~23
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=afba0b80b977b2a8f16234f2acd982f82710ba33;p=thirdparty%2Fkernel%2Flinux.git

random: do not take pool spinlock at boot

Since rand_initialize() is run while interrupts are still off and
nothing else is running, we don't need to repeatedly take and release
the pool spinlock, especially in the RDSEED loop.

Reviewed-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---

diff --git a/drivers/char/random.c b/drivers/char/random.c
index 26cbfcaa3b783..0541066e2e5c1 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -978,10 +978,10 @@ int __init rand_initialize(void)
 			rv = random_get_entropy();
 			arch_init = false;
 		}
-		mix_pool_bytes(&rv, sizeof(rv));
+		_mix_pool_bytes(&rv, sizeof(rv));
 	}
-	mix_pool_bytes(&now, sizeof(now));
-	mix_pool_bytes(utsname(), sizeof(*(utsname())));
+	_mix_pool_bytes(&now, sizeof(now));
+	_mix_pool_bytes(utsname(), sizeof(*(utsname())));
 
 	extract_entropy(base_crng.key, sizeof(base_crng.key));
 	++base_crng.generation;