From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 25 Nov 2019 20:12:06 +0000 (+0200)
Subject: lib: connection: Remove assert for remote_port != 0
X-Git-Tag: 2.3.9~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=afe5e1b0ada25efe7b46c44fecc89651bca874e5;p=thirdparty%2Fdovecot%2Fcore.git

lib: connection: Remove assert for remote_port != 0

This can happen if connection_init_server_ip() is called with remote_ip set
but not remote_port. Alternative fix might be to move the assert to it.
---

diff --git a/src/lib/connection.c b/src/lib/connection.c
index 91310d9c7a..91b1e34ca0 100644
--- a/src/lib/connection.c
+++ b/src/lib/connection.c
@@ -383,7 +383,6 @@ connection_update_properties(struct connection *conn)
 
 	if (conn->remote_ip.family != 0) {
 		/* remote IP was already set */
-		i_assert(conn->remote_port != 0);
 	} else if (conn->unix_peer_checked) {
 		/* already checked */
 	} else if (fd < 0) {