From: Aki Tuomi <aki.tuomi@open-xchange.com>
Date: Thu, 23 Jan 2020 08:42:20 +0000 (+0200)
Subject: doveadm: doveadm-mail-mailbox-metadata - Handle error in doveadm_print_istream
X-Git-Tag: 2.3.10~105
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=afe67e7c30234b846281b3146ebc6ea572a88288;p=thirdparty%2Fdovecot%2Fcore.git

doveadm: doveadm-mail-mailbox-metadata - Handle error in doveadm_print_istream

Found by coverity
---

diff --git a/src/doveadm/doveadm-mail-mailbox-metadata.c b/src/doveadm/doveadm-mail-mailbox-metadata.c
index 2fad6e97de..c1715ec1be 100644
--- a/src/doveadm/doveadm-mail-mailbox-metadata.c
+++ b/src/doveadm/doveadm-mail-mailbox-metadata.c
@@ -2,6 +2,7 @@
 
 #include "lib.h"
 #include "str.h"
+#include "istream.h"
 #include "mail-namespace.h"
 #include "mail-storage.h"
 #include "doveadm-print.h"
@@ -219,7 +220,12 @@ cmd_mailbox_metadata_get_run(struct doveadm_mail_cmd_context *_ctx,
 		/* not found, print as empty */
 		doveadm_print("");
 	} else if (value.value_stream != NULL) {
-		doveadm_print_istream(value.value_stream);
+		if (doveadm_print_istream(value.value_stream) < 0) {
+			i_error("read(%s) failed: %s",
+				i_stream_get_name(value.value_stream),
+				i_stream_get_error(value.value_stream));
+			ret = -1;
+		}
 	} else {
 		doveadm_print(value.value);
 	}