From: Nick Hudson Date: Tue, 23 Apr 2019 06:36:21 +0000 (+0100) Subject: target/hppa: Always return EXCP_DMAR for protection id trap X-Git-Tag: v4.1.0-rc0~139^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=affdb7e6ba23f8160cb88e11f83db54a35f03d6b;p=thirdparty%2Fqemu.git target/hppa: Always return EXCP_DMAR for protection id trap The EXCP_DMP trap is considered legacy. "In PA-RISC 1.1 (Second Edition) and later revisions, processors must use traps 26, 27,and 28 which provide equivalent functionality" Signed-off-by: Nick Hudson Message-Id: <20190423063621.8203-3-nick.hudson@gmx.co.uk> Signed-off-by: Richard Henderson --- diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index c9b57d07c33..77fb5448386 100644 --- a/target/hppa/mem_helper.c +++ b/target/hppa/mem_helper.c @@ -154,8 +154,7 @@ int hppa_get_physical_address(CPUHPPAState *env, vaddr addr, int mmu_idx, if (unlikely(!(prot & type))) { /* The access isn't allowed -- Inst/Data Memory Protection Fault. */ - ret = (type & PAGE_EXEC ? EXCP_IMP : - prot & PAGE_READ ? EXCP_DMP : EXCP_DMAR); + ret = (type & PAGE_EXEC) ? EXCP_IMP : EXCP_DMAR; goto egress; }