From: Jan Beulich <jbeulich@suse.com>
Date: Fri, 15 Aug 2025 10:21:24 +0000 (+0200)
Subject: bfd/ELF/PPC: make ppc_build_one_stub()'s stub_str[] static
X-Git-Tag: gdb-17-branchpoint~301
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b011ae9fef4192a2b8c108eeb80c9cf20e8746d5;p=thirdparty%2Fbinutils-gdb.git

bfd/ELF/PPC: make ppc_build_one_stub()'s stub_str[] static

There's no reason to have the compiler materialize objects onto the
stack.

In fact we can save some space and a level of indirection (and hence
relocation entries in the final binary) by converting to an array of
char[12] or larger. Pick char[16] for easier / faster calculations.
---

diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 78680630c6e..2cacc9e27a2 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -12226,9 +12226,9 @@ ppc_build_one_stub (struct bfd_hash_entry *gen_entry, void *in_arg)
       struct elf_link_hash_entry *h;
       size_t len1, len2;
       char *name;
-      const char *const stub_str[] = { "long_branch",
-				       "plt_branch",
-				       "plt_call" };
+      static const char stub_str[][16] = { "long_branch",
+					   "plt_branch",
+					   "plt_call" };
 
       len1 = strlen (stub_str[stub_entry->type.main - 1]);
       len2 = strlen (stub_entry->root.string);