From: Pablo Neira Ayuso Date: Thu, 27 Jan 2022 12:40:38 +0000 (+0100) Subject: netfilter: nf_tables: remove assignment with no effect in chain blob builder X-Git-Tag: v5.17-rc3~29^2~29^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b07f413732549e5a96e891411fbb5980f2d8e5a1;p=thirdparty%2Flinux.git netfilter: nf_tables: remove assignment with no effect in chain blob builder cppcheck possible warnings: >> net/netfilter/nf_tables_api.c:2014:2: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg] ptr += offsetof(struct nft_rule_dp, data); ^ Reported-by: kernel test robot Signed-off-by: Pablo Neira Ayuso --- diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index cf454f8ca2b09..5fa16990da951 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -2011,7 +2011,6 @@ static void nft_last_rule(struct nft_rule_blob *blob, const void *ptr) prule = (struct nft_rule_dp *)ptr; prule->is_last = 1; - ptr += offsetof(struct nft_rule_dp, data); /* blob size does not include the trailer rule */ }