From: Charles-François Natali Date: Wed, 24 Aug 2011 18:07:54 +0000 (+0200) Subject: Issue12810: Remove check for negative unsigned value in socketmodule.c. Patch X-Git-Tag: v3.3.0a1~1625 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b09f25e9a3ed33be8bff5e92d14e0fc7f638dc07;p=thirdparty%2FPython%2Fcpython.git Issue12810: Remove check for negative unsigned value in socketmodule.c. Patch by Joel Stanley. --- diff --git a/Misc/ACKS b/Misc/ACKS index e7346082d789..e40e40b51dd4 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -898,6 +898,7 @@ Nathan Srebro RajGopal Srinivasan Quentin Stafford-Fraser Frank Stajano +Joel Stanley Oliver Steele Greg Stein Chris Stern diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c index 5878ebb0d3e8..9372feaa6eeb 100644 --- a/Modules/socketmodule.c +++ b/Modules/socketmodule.c @@ -1749,7 +1749,7 @@ cmsg_min_space(struct msghdr *msg, struct cmsghdr *cmsgh, size_t space) static const size_t cmsg_len_end = (offsetof(struct cmsghdr, cmsg_len) + sizeof(cmsgh->cmsg_len)); - if (cmsgh == NULL || msg->msg_control == NULL || msg->msg_controllen < 0) + if (cmsgh == NULL || msg->msg_control == NULL) return 0; if (space < cmsg_len_end) space = cmsg_len_end;