From: Markus Elfring Date: Sat, 4 Apr 2020 14:45:57 +0000 (+0200) Subject: hwrng: omap - Delete an error message in of_get_omap_rng_device_details() X-Git-Tag: v5.8-rc1~236^2~101 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b111418a226f20d3e0b00dbe40bbc4e20b9c2ab5;p=thirdparty%2Fkernel%2Flinux.git hwrng: omap - Delete an error message in of_get_omap_rng_device_details() The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Herbert Xu --- diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c index 65952393e1bb8..7290c603fcb8e 100644 --- a/drivers/char/hw_random/omap-rng.c +++ b/drivers/char/hw_random/omap-rng.c @@ -392,11 +392,8 @@ static int of_get_omap_rng_device_details(struct omap_rng_dev *priv, if (of_device_is_compatible(dev->of_node, "ti,omap4-rng") || of_device_is_compatible(dev->of_node, "inside-secure,safexcel-eip76")) { irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "%s: error getting IRQ resource - %d\n", - __func__, irq); + if (irq < 0) return irq; - } err = devm_request_irq(dev, irq, omap4_rng_irq, IRQF_TRIGGER_NONE, dev_name(dev), priv);