From: Harald Hoyer <harald@redhat.com>
Date: Fri, 26 Mar 2021 09:29:23 +0000 (+0100)
Subject: fix(crypt-gpg): shellcheck for modules.d/91crypt-gpg
X-Git-Tag: 054~197
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b13092751407bb9fba3e445c1642ac0b2d8b318d;p=thirdparty%2Fdracut.git

fix(crypt-gpg): shellcheck for modules.d/91crypt-gpg
---

diff --git a/modules.d/91crypt-gpg/.shchkdir b/modules.d/91crypt-gpg/.shchkdir
new file mode 100644
index 000000000..e69de29bb
diff --git a/modules.d/91crypt-gpg/crypt-gpg-lib.sh b/modules.d/91crypt-gpg/crypt-gpg-lib.sh
index e66feb7d3..0613803a6 100755
--- a/modules.d/91crypt-gpg/crypt-gpg-lib.sh
+++ b/modules.d/91crypt-gpg/crypt-gpg-lib.sh
@@ -29,8 +29,10 @@ gpg_decrypt() {
     # program needed with GnuPG < 2.1), making for uncomplicated
     # integration with the existing codebase.
     local useSmartcard="0"
-    local gpgMajorVersion="$(gpg --version | sed -n 1p | sed -n -r -e 's|.* ([0-9]*).*|\1|p')"
-    local gpgMinorVersion="$(gpg --version | sed -n 1p | sed -n -r -e 's|.* [0-9]*\.([0-9]*).*|\1|p')"
+    local gpgMajorVersion
+    local gpgMinorVersion
+    gpgMajorVersion="$(gpg --version | sed -n 1p | sed -n -r -e 's|.* ([0-9]*).*|\1|p')"
+    gpgMinorVersion="$(gpg --version | sed -n 1p | sed -n -r -e 's|.* [0-9]*\.([0-9]*).*|\1|p')"
 
     if [ "${gpgMajorVersion}" -ge 2 ] && [ "${gpgMinorVersion}" -ge 1 ] \
         && [ -f /root/crypt-public-key.gpg ] && getargbool 1 rd.luks.smartcard; then
@@ -38,7 +40,8 @@ gpg_decrypt() {
         echo "allow-loopback-pinentry" >> "$gpghome/gpg-agent.conf"
         GNUPGHOME="$gpghome" gpg-agent --quiet --daemon
         GNUPGHOME="$gpghome" gpg --quiet --no-tty --import < /root/crypt-public-key.gpg
-        local smartcardSerialNumber="$(GNUPGHOME=$gpghome gpg --no-tty --card-status \
+        local smartcardSerialNumber
+        smartcardSerialNumber="$(GNUPGHOME=$gpghome gpg --no-tty --card-status \
             | sed -n -r -e 's|Serial number.*: ([0-9]*)|\1|p' | tr -d '\n')"
         if [ -n "${smartcardSerialNumber}" ]; then
             inputPrompt="PIN (OpenPGP card ${smartcardSerialNumber})"
diff --git a/modules.d/91crypt-gpg/module-setup.sh b/modules.d/91crypt-gpg/module-setup.sh
index c2f91c276..4d33df175 100755
--- a/modules.d/91crypt-gpg/module-setup.sh
+++ b/modules.d/91crypt-gpg/module-setup.sh
@@ -40,8 +40,11 @@ sc_public_key() {
 
 # CCID Smartcard support requires GnuPG >= 2.1 with scdaemon and libusb
 sc_supported() {
-    local gpgMajor="$(gpg --version | sed -n 1p | sed -n -r -e 's|.* ([0-9]*).*|\1|p')"
-    local gpgMinor="$(gpg --version | sed -n 1p | sed -n -r -e 's|.* [0-9]*\.([0-9]*).*|\1|p')"
+    local gpgMajor
+    local gpgMinor
+    gpgMajor="$(gpg --version | sed -n 1p | sed -n -r -e 's|.* ([0-9]*).*|\1|p')"
+    gpgMinor="$(gpg --version | sed -n 1p | sed -n -r -e 's|.* [0-9]*\.([0-9]*).*|\1|p')"
+
     if [[ ${gpgMajor} -gt 2 || ${gpgMajor} -eq 2 && ${gpgMinor} -ge 1 ]] \
         && require_binaries gpg-agent \
         && require_binaries gpg-connect-agent \