From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 5 Mar 2025 14:04:21 +0000 (+0100)
Subject: qemu_validate: Check whether UEFI shim is supported
X-Git-Tag: v11.2.0-rc1~210
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b136e492c55bbbfd073f7461de9ed420ef90cf24;p=thirdparty%2Flibvirt.git

qemu_validate: Check whether UEFI shim is supported

If UEFI shim is specified in domain XML but QEMU is too old, then
report an error.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
---

diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 4ab7af36f3..f117441ece 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -763,6 +763,13 @@ qemuValidateDomainDefBoot(const virDomainDef *def,
         }
     }
 
+    if (def->os.shim &&
+        !virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_SHIM)) {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                       _("shim is not supported by this QEMU binary"));
+        return -1;
+    }
+
     return 0;
 }