From: Achilles Gaikwad Date: Mon, 28 Jan 2019 19:03:08 +0000 (-0600) Subject: xfs_quota: fix false error reporting of project inheritance flag is not set X-Git-Tag: v4.20.0-rc1~8 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b136f48b19a5b8e788aceb4b80e97d6ae9edd0ea;p=thirdparty%2Fxfsprogs-dev.git xfs_quota: fix false error reporting of project inheritance flag is not set After kernel commit: 9336e3a7 "xfs: project id inheritance is a directory only flag" xfs stopped setting the project inheritance flag on regular files, but userspace quota code still checks for it and will now issue the error: "project inheritance flag is not set" for every regular file during quotacheck. Fix this by only checking for the flag on directories. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1663502 Reported-by: Steven Gardner Signed-off-by: Achilles Gaikwad Reviewed-by: Darrick J. Wong Signed-off-by: Eric Sandeen --- diff --git a/quota/project.c b/quota/project.c index 78ede9e5c..7c22947c7 100644 --- a/quota/project.c +++ b/quota/project.c @@ -114,7 +114,7 @@ check_project( printf(_("%s - project identifier is not set" " (inode=%u, tree=%u)\n"), path, fsx.fsx_projid, (unsigned int)prid); - if (!(fsx.fsx_xflags & FS_XFLAG_PROJINHERIT)) + if (!(fsx.fsx_xflags & FS_XFLAG_PROJINHERIT) && S_ISDIR(stat->st_mode)) printf(_("%s - project inheritance flag is not set\n"), path); }