From: Phil Sutter <phil@nwl.cc>
Date: Sun, 19 Nov 2023 12:18:26 +0000 (+0100)
Subject: xshared: struct xt_cmd_parse::xlate is unused
X-Git-Tag: v1.8.11~166
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b180d9c86d2cce6ab6fd3e3617faf320a8a1babb;p=thirdparty%2Fiptables.git

xshared: struct xt_cmd_parse::xlate is unused

Drop the boolean, it was meant to disable some existence checks in
do_parse() prior to the caching rework. Now that do_parse() runs before
any caching is done, the checks in question don't exist anymore so drop
this relict.

Fixes: a7f1e208cdf9c ("nft: split parsing from netlink commands")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/iptables/xshared.h b/iptables/xshared.h
index 55863854..c77556a1 100644
--- a/iptables/xshared.h
+++ b/iptables/xshared.h
@@ -284,7 +284,6 @@ struct xt_cmd_parse {
 	bool				restore;
 	int				line;
 	int				verbose;
-	bool				xlate;
 	struct xt_cmd_parse_ops		*ops;
 };
 
diff --git a/iptables/xtables-translate.c b/iptables/xtables-translate.c
index ea9dce20..ad443112 100644
--- a/iptables/xtables-translate.c
+++ b/iptables/xtables-translate.c
@@ -259,7 +259,6 @@ static int do_command_xlate(struct nft_handle *h, int argc, char *argv[],
 		.table		= *table,
 		.restore	= restore,
 		.line		= line,
-		.xlate		= true,
 		.ops		= &h->ops->cmd_parse,
 	};
 	struct iptables_command_state cs = {