From: Jakub Kicinski Date: Wed, 13 Aug 2025 00:32:44 +0000 (-0700) Subject: Merge branch 'netconsole-reuse-netpoll_parse_ip_addr-in-configfs-helpers' X-Git-Tag: v6.18-rc1~132^2~441 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b1987f1e05b7dd2e08b51967cc187dbe8092cbd9;p=thirdparty%2Fkernel%2Fstable.git Merge branch 'netconsole-reuse-netpoll_parse_ip_addr-in-configfs-helpers' Breno Leitao says: ==================== netconsole: reuse netpoll_parse_ip_addr in configfs helpers This patchset refactors the IP address parsing logic in the netconsole driver to eliminate code duplication and improve maintainability. The changes centralize IPv4 and IPv6 address parsing into a single function (netpoll_parse_ip_addr). For that, it needs to teach netpoll_parse_ip_addr() to handle strings with newlines, which is the type of string coming from configfs. Background The netconsole driver currently has duplicate IP address parsing logic in both local_ip_store() and remote_ip_store() functions. This duplication increases the risk of inconsistencies and makes the code harder to maintain. Benefits * Reduced code duplication: ~40 lines of duplicate parsing logic eliminated * Improved robustness: Centralized parsing reduces the chance of inconsistencies * Easier to maintain: Code follow more the netdev way v3: https://lore.kernel.org/20250723-netconsole_ref-v3-0-8be9b24e4a99@debian.org v2: https://lore.kernel.org/20250721-netconsole_ref-v2-0-b42f1833565a@debian.org v1: https://lore.kernel.org/20250718-netconsole_ref-v1-0-86ef253b7a7a@debian.org ==================== Link: https://patch.msgid.link/20250811-netconsole_ref-v4-0-9c510d8713a2@debian.org Signed-off-by: Jakub Kicinski --- b1987f1e05b7dd2e08b51967cc187dbe8092cbd9