From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 21 Nov 2025 13:39:40 +0000 (+0100)
Subject: virDomainDiskDefCheckABIStability: Add missing check for 'removable' property
X-Git-Tag: v11.10.0-rc1~15
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b1a2ea971db2365e7cd30e57bf03e990a41bf2fe;p=thirdparty%2Flibvirt.git

virDomainDiskDefCheckABIStability: Add missing check for 'removable' property

The 'removable' state is guest-visible.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 6e47ccb23d..af1b682499 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -20896,6 +20896,14 @@ virDomainDiskDefCheckABIStability(virDomainDiskDef *src,
         return false;
     }
 
+    if (src->removable != dst->removable) {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                       _("Target disk 'removable' property %1$s does not match source %2$s"),
+                       virTristateSwitchTypeToString(dst->removable),
+                       virTristateSwitchTypeToString(src->removable));
+        return false;
+    }
+
     if (src->queues != dst->queues) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                        _("Target disk queue count %1$u does not match source %2$u"),