From: Mark Wielaard Date: Fri, 3 Mar 2023 13:13:49 +0000 (+0100) Subject: readelf: Fix use-after-free ebl pointer issue X-Git-Tag: elfutils-0.189~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=b1fa74956793141771a6514c445d0884fdef3841;p=thirdparty%2Felfutils.git readelf: Fix use-after-free ebl pointer issue With -flto gcc 13 sees that we use the ebl pointer after closing and freeing it. In function ‘process_elf_file’, inlined from ‘process_dwflmod’ at readelf.c:818:3: readelf.c:1070:6: error: pointer ‘ebl_18’ used after ‘free’ [-Werror=use-after-free] 1070 | if (pure_ebl != ebl) | ^ In function ‘ebl_closebackend’, inlined from ‘process_elf_file’ at readelf.c:1068:3, inlined from ‘process_dwflmod’ at readelf.c:818:3: ../libebl/eblclosebackend.c:47:7: note: call to ‘free’ here 47 | free (ebl); | ^ Fix by only calling ebl_closebackend after using it in the comparison. Signed-off-by: Mark Wielaard --- diff --git a/src/ChangeLog b/src/ChangeLog index 699d98ee8..c26dafdd2 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,8 @@ +2023-03-03 Mark Wielaard + + * readelf (process_elf_file): ebl_closebackend only after + comparing ebl pointer. + 2023-02-12 Mark Wielaard * readelf.c (print_attributes): Add comment about check. diff --git a/src/readelf.c b/src/readelf.c index 0f13874f5..6950204ef 100644 --- a/src/readelf.c +++ b/src/readelf.c @@ -1065,13 +1065,14 @@ process_elf_file (Dwfl_Module *dwflmod, int fd) if (print_string_sections) print_strings (ebl); - ebl_closebackend (ebl); - if (pure_ebl != ebl) { + ebl_closebackend (ebl); ebl_closebackend (pure_ebl); elf_end (pure_elf); } + else + ebl_closebackend (ebl); }